Attention is currently required from: Krystian Hebel, Martin L Roth, Matt DeVillier, Michał Żygowski, Piotr Król.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79852?usp=email )
Change subject: mb/pcengines/apu2/BiosCallOuts: don't have binaryPI clear LPC decodes
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
i'll have a look at it, but that sounds like the better solution to me
had a look at the stoney binarypi source and ran a test; setting FchParams->LegacyFree to 0 is the much better approach
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79852?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91ef4423bd7bf6c1d7a175336f0f89479f2cde02
Gerrit-Change-Number: 79852
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Tue, 09 Jan 2024 22:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment