Attention is currently required from: Marc Jones, Martin Roth, Rocky Phagura, Arthur Heymans, Patrick Rudolph.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49913 )
Change subject: soc/intel/xeon_sp/cpx: Move soc_final to finalize.c
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49913/comment/9c061185_12cd1a8e
PS1, Line 10: expanded and used by intel/soc devices.
chip_operations.final() and ON_EXIT of BS_PAYLOAD_LOAD are executed at different timing. Locking down things as soon as they can be locked is generally better than locking down them later. So I would choose to have both of them co-exist. That being said, I am fine with this approach.
File src/soc/intel/xeon_sp/cpx/finalize.c:
https://review.coreboot.org/c/coreboot/+/49913/comment/230b39e0_7a95e2ea
PS1, Line 39: BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, soc_finalize, NULL);
I suppose BS_OS_RESUME is more for laptop. xeon_sp as server processor, OS sleep/resume feature is not needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c3319cbbfc44e6232033e9d7f299f45d9f22b07
Gerrit-Change-Number: 49913
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rocky Phagura
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 26 Jan 2021 20:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment