Attention is currently required from: Damien Zammit, Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 )
Change subject: hp/z220_series: Convert z220_sff_workstation into variant ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/hp/z220_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/62808/comment/e81b4915_3cc021e1 PS1, Line 1: BOARD_HP_Z220_SERIES
Subjective and not strictly required.
It's not strictly required, but the _COMMON suffix is an indication for the reader that it serves as base for other options. So this is important.
File src/mainboard/hp/z220_series/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62808/comment/ca820ec4_c07fcb9e PS1, Line 3: select BOARD_HP_Z220_SERIES
This only makes sense if there is a "base" board and variants on the base board. […]
Thanks for pointing me to mb/hp/snb_ivb_laptops. I have just reworked it in CB:62816. My reasoning there also applies to this case.