Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu, Kapil Porwal, Pranava Y N, Ravishankar Sarawadi, Saurabh Mishra, Wonkyu Kim.
Subrata Banik has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/83772?usp=email )
Change subject: soc/intel/ptl: Add SoC ACPI directory for Panther Lake
......................................................................
Patch Set 43:
(1 comment)
File src/soc/intel/pantherlake/acpi/southbridge.asl:
https://review.coreboot.org/c/coreboot/+/83772/comment/df316758_4a7b2258?usp... :
PS23, Line 47: /* UFS 0:17:0 */
: #include "ufs.asl"
Hi Subrata, i have added a TODO to add ufs.asl for PTL-U SKU.
To porperly manage this inclusion using SOC type Kconfig, we have to introduce a PTL-U type SOC. Let me know if we can do that.
Suggestion:
config SOC_INTEL_PANTHERLAKE_U
bool
depends on !SOC_INTEL_PANTHERLAKE_H
select SOC_INTEL_PANTHERLAKE_BASE
It would be ideal for this Kconfig to select `SOC_INTEL_PANTHERLAKE_UH` and include any additional selections for the UFS Kconfig if we add one later. Because UFS is a PCI device, I don't believe we need a Kconfig guard to prevent the default from being added. However, we may require a Kconfig for passing FSP UPDs for UFS, while PTL-H (25W) may not have UFS enabled. However, if FSP is intelligent enough to include these things internally, I don't think we need to add another Kconfig to indicate whether we're building fatcat with PTL-UH or PTL-U.
help
Choose this option if the mainboard is built using PTL-U 4 P-cores +0
E- cores + 4 LP E-cores +4 Xe-cores system-on-a-chip (SoC).
Note, PTL-U processor line is offered in a single package platform that
includes the Compute tile, the PCD tile, and the GFX tile on the same
package.
as I have mentioned previously this is just base CLs and not everything is expected to land as part of these initial Cls. Please avoid adding more stuffs and make the review complicated
if you wish to add PTL-U (which not existed until next year sometime as I learn) what is the point of adding dedicated Kconfig. we will be still selecting PTL-UH SoC from fatcat.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83772?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5cf899b049cb8eb27b4ea30c7f3ce7a14884f15
Gerrit-Change-Number: 83772
Gerrit-PatchSet: 43
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 16 Aug 2024 08:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com