[coreboot-gerrit] [M] Change in coreboot[master]: mainboard/google: move tpm_tis to AMD common code

[Matt DeVillier (Code Review)]

Attention is currently required from: Eric Lai, Felix Held, Fred Reitberger, Grzegorz Bernacki, Jason Glenesk, Jason Nien, Jon Murphy, Martin Roth, Raul Rangel.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75621?usp=email )

Change subject: mainboard/google: move tpm_tis to AMD common code
......................................................................

Patch Set 1:

(1 comment)

File src/soc/amd/common/block/gpio/tpm_tis.c:

https://review.coreboot.org/c/coreboot/+/75621/comment/6d4fd459_2485aa3b :
PS1, Line 11: if (CONFIG(BOARD_GOOGLE_NIPPERKIN) && board_id() == 1)
> you can provide board level call back and return CONFIG_TPM_TIS_INTERRUPT, than you still have chang […]

or you can make the common code implementation of tis_plat_irq_status() a weak function which simply returns gpio_interrupt_status(CONFIG_TPM_TIS_INTERRUPT), and have guybrush override it like it does not. having all boards implement a function that returns CONFIG_TPM_TIS_INTERRUPT doesn't really improve the current situation at all IMO