Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46608 )
Change subject: haswell: Add Intel TXT support in romstage
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46608/5/src/security/intel/txt/comm...
File src/security/intel/txt/common.c:
https://review.coreboot.org/c/coreboot/+/46608/5/src/security/intel/txt/comm...
PS5, Line 310: //write32((void *)MCU_BASE_ADDR, 0xffe1a990);
Thanks for the pointer. We don't set up the APs anywhere. […]
I'm going to merge this as-is, as I'd like to ensure the upcoming coreboot release has the means to recover from TXT-blocked memory. Even if the current approach doesn't always succeed on the first try, it's much better than not trying at all.
I've updated the commit message to explain this issue, and I will look into implementing the AP init sequence in the (hopefully near) future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46608
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60beb7d79a30f460bbd5d94e4cba0244318c124e
Gerrit-Change-Number: 46608
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Nov 2020 23:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment