Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31979 )
Change subject: soc/nvidia/tegra{124,210}: Use 'halt()' already defined in <halt.h> ......................................................................
Patch Set 1: Code-Review-1
No, wait, this doesn't work like this. The lp0/ directory is special and not linked into the rest of coreboot. You can't pull in code from halt.c. The proper fix is to remove the <halt.h> #include again.
This was originally supposed to be standalone and we just put it into coreboot because the Linux kernel didn't want to take it and we didn't find a better repo for it. We made an exception for <stdint.h> because that's a standard POSIX header, so you can somewhat expect what it contains and that it won't pull an unpredictable chain of other header in behind it. But we shouldn't pull in anything else. That's why I also think this should probably not use <device/mmio.h>, although that should theoretically work because those are all inlines.