Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62322 )
Change subject: util/futility: Don't echo the warning message unless it fails ......................................................................
util/futility: Don't echo the warning message unless it fails
Currently, all of the commands for building futility are printed as they are run. This change skips printing the check for libcrypto unless the check actually fails. This prevents the error from being displayed when there isn't actually a problem.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: I9ef36c0b64f7cd69d19b8faabd165ef6651c838e Reviewed-on: https://review.coreboot.org/c/coreboot/+/62322 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M util/futility/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc index 45627a9..6a56deb 100644 --- a/util/futility/Makefile.inc +++ b/util/futility/Makefile.inc @@ -16,7 +16,7 @@
.PHONY: check-openssl-presence check-openssl-presence: - $(HOSTPKGCONFIG) --exists libcrypto || \ + @$(HOSTPKGCONFIG) --exists libcrypto || \ (echo "Error: Ensure that pkg-config and openssl's libcrypto, including header files, are installed."; exit 1)
$(objutil)/futility/futility: $(VBOOT_FUTILITY)