Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31520 )
Change subject: soc/intel/cannonlake: Assign FSP UPDs for HPD and Data/CLK of DDI ports
......................................................................
Patch Set 7:
(2 comments)
Patch Set 6:
Verified on hatch, yet to be verified on sarien and arcada.
Verified on sarien and arcada.
https://review.coreboot.org/#/c/31520/6/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/31520/6/src/mainboard/google/sarien/variants...
PS6, Line 49: DdiPortDHpd
This is not used as a hotplug pin on arcada: […]
Done
https://review.coreboot.org/#/c/31520/6/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/31520/6/src/mainboard/google/sarien/variants...
PS6, Line 53: DdiPortDHpd
This is not used as a hotplug pin on sarien: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31520
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0c172cd3d087fc8f49b01ab23feffdababf7166
Gerrit-Change-Number: 31520
Gerrit-PatchSet: 7
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 Mar 2019 04:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment