build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63075 )
Change subject: mb/google/dedede/var/drawcia: Add FW_CONFIG probe for EXT_VR ......................................................................
Patch Set 1:
(6 comments)
File src/mainboard/google/dedede/variants/drawcia/ramstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144625): https://review.coreboot.org/c/coreboot/+/63075/comment/091c17e2_398209a7 PS1, Line 12: struct soc_intel_jasperlake_config *cfg = config_of_soc(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144625): https://review.coreboot.org/c/coreboot/+/63075/comment/28402013_8bec2e25 PS1, Line 12: struct soc_intel_jasperlake_config *cfg = config_of_soc(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144625): https://review.coreboot.org/c/coreboot/+/63075/comment/18e3843f_6ddaa801 PS1, Line 14: if (fw_config_probe(FW_CONFIG(EXT_VR, EXT_VR_ABSENT))) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144625): https://review.coreboot.org/c/coreboot/+/63075/comment/bdfb6467_02480e16 PS1, Line 14: if (fw_config_probe(FW_CONFIG(EXT_VR, EXT_VR_ABSENT))) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144625): https://review.coreboot.org/c/coreboot/+/63075/comment/31f314c7_b45469de PS1, Line 15: cfg->disable_external_bypass_vr = 1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144625): https://review.coreboot.org/c/coreboot/+/63075/comment/36de0eca_a6630b93 PS1, Line 15: cfg->disable_external_bypass_vr = 1; please, no spaces at the start of a line