build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44717 )
Change subject: soc/mediatek/mt8192: Do write leveling training ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44717/2/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44717/2/src/soc/mediatek/mt8192/dra... PS2, Line 4213: if (state) suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/44717/2/src/soc/mediatek/mt8192/dra... PS2, Line 4215: else suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/44717/2/src/soc/mediatek/mt8192/dra... PS2, Line 4278: shift_ui = (wl_dqs_final_delay[rank][byte] / pi_bound) * (pi_bound / 32); line over 96 characters