Attention is currently required from: Alicja Michalska, Name of user not set #1004406.
Name of user not set #1004406 has posted comments on this change by Name of user not set #1004406. ( https://review.coreboot.org/c/coreboot/+/65225?usp=email )
Change subject: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake)
......................................................................
Patch Set 21:
(2 comments)
File src/mainboard/asrock/h370m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/65225/comment/c37fd090_c6993a09?usp... :
PS20, Line 6: register "s0ix_enable" = "1"
you are right. removing s0ix_enable and setting PchPmSlpS3* result in a correct sleep down. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/65225/comment/ada69cdc_fe9dee6e?usp... :
PS20, Line 115: device ref lpc_espi on
thanks for that information. i will contact nuvoton. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65225?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79302247311471153ebbba991081365d9265791b
Gerrit-Change-Number: 65225
Gerrit-PatchSet: 21
Gerrit-Owner: Name of user not set #1004406
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alicja Michalska
ahplka19@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Name of user not set #1004406
Gerrit-Comment-Date: Tue, 24 Dec 2024 13:55:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alicja Michalska
ahplka19@gmail.com
Comment-In-Reply-To: Name of user not set #1004406
