Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31993 )
Change subject: gale: add dev switch back as physical presence GPIO ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Looks like we are one character short... =(
src/mainboard/google/gale/chromeos.c: In function 'fill_lb_gpios': src/mainboard/google/gale/chromeos.c:74:37: error: initializer-string for array of chars is too long [-Werror] {PP_SW, PP_POL, read_gpio(PP_SW), "physical presence"}, ^~~~~~~~~~~~~~~~~~~ src/mainboard/google/gale/chromeos.c:74:37: note: (near initialization for 'chromeos_gpios[0].name')
http://review.coreboot.org/866 100 +struct lb_gpio { 101 + uint32_t port; 102 + uint32_t polarity; 103 + uint32_t value; 104 +#define GPIO_MAX_NAME_LENGTH 16 105 + uint8_t name[GPIO_MAX_NAME_LENGTH]; 106 +};
Given that this data is shared across the boundary from coreboot to the payload, is GPIO_MAX_NAME_LENGTH something that we can change?
Alternatively, any clever abbreviations for "physical presence"?
https://review.coreboot.org/#/c/31993/1/src/mainboard/google/gale/chromeos.c File src/mainboard/google/gale/chromeos.c:
https://review.coreboot.org/#/c/31993/1/src/mainboard/google/gale/chromeos.c... PS1, Line 74: DEV_SW
PP_SW?
Done