[coreboot-gerrit] [S] Change in coreboot[main]: mb/intel/beechnutcity_crb: Update SMBIOS info for type 0,1,2,3

[Shuo Liu (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, David Hendricks, Felix Singer, Jincheng Li, Lean Sheng Tan, Patrick Rudolph.

Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83327?usp=email )

Change subject: mb/intel/beechnutcity_crb: Update SMBIOS info for type 0,1,2,3
......................................................................

Patch Set 6:

(3 comments)

File src/mainboard/intel/beechnutcity_crb/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83327/comment/d40f4ec3_f78ccbea?usp... :
PS5, Line 14: 	return "UNKNOWN";
> Default if unset is the coreboot version, which IMHO is more useful than "UNKNOWN": https://github. […]

Done

https://review.coreboot.org/c/coreboot/+/83327/comment/db3a9d96_9511ed0a?usp... :
PS5, Line 24: 	return "UNKNOWN";
> Most of these default to empty strings. Will this code be changed in the future (e.g. […]

There is no plan to further update the board info, the intention of these changes is to set examples for variant board changes in future. The smbios_defaults.c definitely helps on this purpose better. I updated this patch accordingly.

https://review.coreboot.org/c/coreboot/+/83327/comment/4e0a285b_8841def4?usp... :
PS5, Line 52: u8 smbios_chassis_power_cords(void)
            : {
            : 	return 1;
            : }
> Same as default, can be omitted: https://github. […]

Done