Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36216 )
Change subject: soc/intel: common,skl,cnl,icl: drop reserved mmio memory size calculation ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36216/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36216/5//COMMIT_MSG@14 PS5, Line 14: Since this will always be equal to 0 I'm not sure I understand or follow. what is 'this'? What this change is doing is actually manipulating the reserved mmio vs ram split which impacts mtrr usage.
https://review.coreboot.org/c/coreboot/+/36216/5/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/36216/5/src/soc/intel/common/block/... PS5, Line 178: mmio_resource(dev, index++, base_k / KiB, size_k / KiB); I'm not sure it matters too much, but this change implicitly marks the PRMRR, trace, and ptt memory as mmio where before it was reserved ram. There will be implications to MTRR usage depending on alignment and size.
i.e. mmio reservation increased in size and reserved ram decreased.
Do you have logs from before and after this change?