Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42348 )
Change subject: Revert "arch|cpu/x86: Add Kconfig option for x86 reset vector"
......................................................................
Patch Set 1:
I haven't looked at the entire patch stack, but can't we put this section aligned to 16 bytes as the last thing. Then we can relocate adding to cbfs? It should all just work from there w/o manually specifying the location in the linker script.
I have somewhat major rework in followups to get top-aligned bootblock for more efficient FLASH usage. Might be good to just separate PCO from the legacy layout completely.
There is CB:40876 as I though the separation of the linker scripts was unnecessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6b2cc2b17133b3207758c72a54abe80fc6356b5
Gerrit-Change-Number: 42348
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 17:39:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment