Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44188 )
Change subject: ec/google/chromeec: Add helper to request AP reset ......................................................................
Patch Set 2:
Patch Set 1:
So there will be some instructions continuing to execute after the AP sends the command and before the EC can perform the reset; I think a call to `halt()` is probably a good idea here. I'm just trying to think where the best place for it is... I'm thinking here is probably the better choice, otherwise it needs to be duplicated for other boards that will require this workaround as well.
Should we wait until we some usage elsewhere. In the case here, CSE Lite driver invokes die() after cse_board_reset. die() inturn invokes halt(). So it will be redundant.