Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33484 )
Change subject: mainboard/facebook/fbg1701: Add FMAP file ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/33484/1/src/mainboard/facebook/fbg1701/Kconf... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/#/c/33484/1/src/mainboard/facebook/fbg1701/Kconf... PS1, Line 57: 0x00800000 Set this to 0x600000 and the default fmap will be very similar
https://review.coreboot.org/#/c/33484/1/src/mainboard/facebook/fbg1701/fmap.... File src/mainboard/facebook/fbg1701/fmap.fmd:
https://review.coreboot.org/#/c/33484/1/src/mainboard/facebook/fbg1701/fmap.... PS1, Line 17: RW_MRC_CACHE@0x200 0x8000 should be 64K aligned iirc.