Attention is currently required from: Hung-Te Lin, Jarried Lin.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83922?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add GPIO driver
......................................................................
Patch Set 4:
(3 comments)
File src/soc/mediatek/mt8196/gpio.c:
https://review.coreboot.org/c/coreboot/+/83922/comment/f1c5fe78_a980bf71?usp... :
PS4, Line 393: return NULL;
Log an error?
https://review.coreboot.org/c/coreboot/+/83922/comment/fc270af6_fe2e5d74?usp... :
PS4, Line 400: return NULL;
Ditto.
File src/soc/mediatek/mt8196/include/soc/gpio_base.h:
PS4:
It’s identical to `src/soc/mediatek/mt8195/include/soc/gpio_base.h`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83922?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6d1e6ef17660308c8de908697ffba6b5f17ff9ae
Gerrit-Change-Number: 83922
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Sat, 17 Aug 2024 19:46:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No