Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )
Change subject: vc/google/chromeos: Add support for new SAR tables revisions ......................................................................
Patch Set 10:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56750/comment/a42383a6_f4ebe36f PS10, Line 12: Please summarize the differences to version 1 and the implementation (antgain, …). Why does the vendor code need to be changed at the same time?
https://review.coreboot.org/c/coreboot/+/56750/comment/954b383c_251596d7 PS10, Line 14: TEST=Check the generated SSDT tables on brya How exactlys
File src/drivers/wifi/generic/Kconfig:
https://review.coreboot.org/c/coreboot/+/56750/comment/b4228734_047581f5 PS10, Line 29: Enable it when wifi driver uses wifi6e/DSM configuration feature. Can both be used at the same time? Is there a way to autodetect the version?
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/56750/comment/f37538f9_e43577f3 PS10, Line 57: printk(BIOS_DEBUG, "failed from getting SAR limits!\n"); Reword to “failed getting SAR limits!” could be separate commit.
https://review.coreboot.org/c/coreboot/+/56750/comment/fb67473f_25c8a007 PS10, Line 135: package_size size_t
https://review.coreboot.org/c/coreboot/+/56750/comment/a2d7002c_4a89892c PS10, Line 221: int i, package_size; size_t