[coreboot-gerrit] New patch to review for coreboot: eae4a7e samus: Use codec internal 1.8V as DACREF source

[Stefan Reinauer]

Stefan Reinauer ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9500

-gerrit

commit eae4a7e89de8a50c5fb580d4dfdc601f4bac40b6
Author: Ben Zhang 
Date:   Wed Dec 10 17:44:18 2014 -0800

samus: Use codec internal 1.8V as DACREF source

This is needed for audio playback after we disconnect PP1800_CODEC
    from DACREF to avoid noise coupled on PP1800_CODEC, which makes
    recording noisy.

For recording, DACREF comes from mic vref pump voltage.
    For playback, DACREF comes from internal 1.8V.

BUG=chrome-os-partner:32953
    BRANCH=samus
    TEST=Set MICBIAS to 2.970V on Samus, playback/recording is clean

Change-Id: I65fb6dbfab54c7c4de6496fd4a0d666baead28ec
    Signed-off-by: Stefan Reinauer 
    Original-Commit-Id: 3e62a61f6cf6042f6d653a827698b55ac86e2d2b
    Original-Change-Id: I27430691e469dd7f4056d99438ce080062b58b9a
    Original-Signed-off-by: Ben Zhang 
    Original-Signed-off-by: Duncan Laurie 
    Original-Reviewed-on: https://chromium-review.googlesource.com/241179
---
 src/mainboard/google/samus/acpi/mainboard.asl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mainboard/google/samus/acpi/mainboard.asl b/src/mainboard/google/samus/acpi/mainboard.asl
index 287f595..2140898 100644
--- a/src/mainboard/google/samus/acpi/mainboard.asl
+++ b/src/mainboard/google/samus/acpi/mainboard.asl
@@ -178,6 +178,7 @@ Scope (_SB.PCI0.I2C0)
    	Name (WAKE, 45) /* DSP_INT (use as codec wake) */

Name (MB1, 1)   /* MICBIAS1 = 2.970V */
+		Name (DACR, 1)  /* Use codec internal 1.8V as DACREF source */
    	Name (DCLK, 0)  /* RT5677_DMIC_CLK1 */
    	Name (PCLK, 1)  /* RT5677_PDM_CLK_DIV2 (~3MHz) */
    	Name (IN1, 1)   /* IN1 differential */
@@ -195,6 +196,7 @@ Scope (_SB.PCI0.I2C0)
    		ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
    		Package () {
    			Package () { "realtek,micbias1", 1 },
+				Package () { "realtek,internal-dacref-en", 1 },
    			Package () { "realtek,in1-differential", 1 },
    			Package () { "realtek,in2-differential", 0 },
    			Package () { "realtek,lout1-differential", 1 },