Attention is currently required from: Frank Wu, John Su, Alan Lee, Martin Roth, Ivy Jian.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49783 )
Change subject: drivers/generic/bayhub_lv2: Add driver for BayHub lv2
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/generic/bayhub_lv2/lv2.h:
https://review.coreboot.org/c/coreboot/+/49783/comment/6c3fc29c_5f8215a0
PS2, Line 29: void board_lv2(struct device *dev);
I'm not sure how this function will be put to use. Personally, I'd instead prefer to create more devicetree options in chip.h to abstract the configuration of this device. Devicetree options default to 0 if not specified.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc1340b1a6fe7063d16c8ea16488d6e2b8b308cc
Gerrit-Change-Number: 49783
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 22 Jan 2021 12:36:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment