Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36924 )
Change subject: lib/fmap: Allow disabling all output in fmap cache ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Is there not a better solution than reducing verbosity of somewhat random parts of coreboot? How about Adding a Kconfig to change the log verbosity per stage?
I'm fine with a better solution, but since these printks made google_meep fail, they're what I kicked out for now.
Note that for the most part, we leave strings in when we reduce the log level, so this mechanism is different from our normal verbosity selection mode (which merely makes printk decide whether to print a string or not).
Looking at the history of the change some more, the strings already existed before (and the print once mechanism and everything). So yes, removal of these strings is indeed rather arbitrary but it worked to get code growth under control ¯_(ツ)_/¯