Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45458 )
Change subject: mb/google/dedede: Enable I2C5 pads ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45458/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/45458/1/src/mainboard/google/dedede... PS1, Line 187: AP_I2C_SUB_SDA
Will told me that in the event they do adopt I2C5 as the final solution, they likely wouldn't rename […]
In the event we are not sure about the plan for other variants, please move this configuration to variants/waddledee/gpio.c. The net name can be updated there, so that we know the purpose of these GPIOs.
We can configure the GPIOs on other variants as and when needed.