Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Paul Menzel, Tim Wawrzynczak, Bernardo Perez Priego.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58099 )
Change subject: mb/intel/adlrvp: Add hook function to return EC in RW status
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/intel/adlrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/58099/comment/d3fdc64a_e1abf60a
PS9, Line 51: get_ec_is_trusted
We decided to revert this get_ec_is_trusted() function for now, and will proceed another reland since there were some GPIOs we did not handled them properly.
(https://review.coreboot.org/c/coreboot/+/57951)
So please remove this function for now, and we will add it back once we are going to re-land get_ec_is_trusted()
But it is still okay to config the EC_IN_RW as the early_gpio in this CL, and only remove this override for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20804db450ab0b3ebe19c51ba2b294a0137d81a7
Gerrit-Change-Number: 58099
Gerrit-PatchSet: 9
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 08:15:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment