Attention is currently required from: Mario Scheithauer.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69384 )
Change subject: drivers/phy/m88e1512: Add new driver for Marvell PHY 88E1512
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
The chosen subdirectory 'phy' might cause confusions as we are here dealing with an ethernet PHY. A better place might be a subdirectory in the 'net' folder or even create a 'mdio' subdirectory to let the interface type decide this.
Let's see what others think about it before changing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24011860caa7bb206770f9779eb34b689293db10
Gerrit-Change-Number: 69384
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Comment-Date: Wed, 09 Nov 2022 07:58:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment