[coreboot-gerrit] Change in coreboot[master]: drivers/intel/pmc_mux/conn: Change usb{23}_port_number fields to devi...

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Reka Norman, Nico Huber, Jeremy Soller, Paul Menzel, Nick Vaccaro, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60143 )

Change subject: drivers/intel/pmc_mux/conn: Change usb{23}_port_number fields to device pointers
......................................................................

Patch Set 4: Code-Review+2

(1 comment)

File src/drivers/intel/pmc_mux/conn/conn.c:

https://review.coreboot.org/c/coreboot/+/60143/comment/e6966160_b296a191 
PS2, Line 60: path.usb.port_id + 1
> Angel: Done, thanks for the suggestion. […]

I'm not sure why the numbering is the way it is currently... but the PMC/kernel expects 1-based port numbers, whereas in coreboot we usually treat them as 0-based, hence the `+ 1`. I wouldn't say they're "wrong" it's just the consumer of them expects a different numbering system than we use.

Although taking another look at how they're used via a quick `git grep '->path.usb.port_id`, it appears they are mostly used for the ACPI device names, and only in a few other places, so maybe it would make sense to change them, but I think that's for another CL.