Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Julius Werner. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56410 )
Change subject: [RFC] kconfig_lint: Drop overly restrictive rules about choice configs ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56410/comment/a12a6d8c_be228e5e PS4, Line 19: On top, the linter treats every occurence of a `config` entry as a : symbol declaration, even when it's just setting a default or adding : selects. Every config entry is treated as a symbol definition because any given config entry could be the symbol declaration. What makes one config entry different than another? That a type is specified vs not being specified? That it comes first, last?
Please keep in mind that when this was written almost every entry had a type associated because people didn't seem to realise that they didn't have to.
If anyone would like to take a stab at writing a better linter, I'd welcome the effort. Before I wrote this, there was absolutely zero checking. Even the kconfig tool itself, which now errors out if there are issues did not do that when this tool was written.
Again, if the coreboot community doesn't think that linting the Kconfigs is a good idea, I have no issue with this being deleted. I actually supported the idea of using kconfiglib, which can do what this linter does and more, but that idea was shot down.