Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31544 )
Change subject: commonlib: Add Bubble sort algorithm
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31544/3/src/include/stdlib.h
File src/include/stdlib.h:
https://review.coreboot.org/#/c/31544/3/src/include/stdlib.h@13
PS3, Line 13: } while (0)
Uhhh... not sure how I feel about this. Using lvalues in macros is commonly frowned upon. […]
edit: Actually, if you do decide to leave it like this, maybe call it SWAP() because then it's clearly not (and not treatable like) a function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31544
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c5e0b5685a907243b58ebe6682078272d316bf6
Gerrit-Change-Number: 31544
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 23 Feb 2019 01:50:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment