Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board
......................................................................
Patch Set 48:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x...
PS41, Line 24: Find out why the polarities from gpio.h gets overwritten by FSP.
@Nico some idea here?
Are you sure the final values, when coreboot is done differ from the `gpio.h`
settings? There is itss_snapshot|restore_irq_polarities() that are supposed
to take care of it...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9
Gerrit-Change-Number: 35427
Gerrit-PatchSet: 48
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 20 Oct 2019 11:11:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment