Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31803 )
Change subject: mb/google/poppy/variant/nami: change the vbt bin loading for bard sku ......................................................................
Patch Set 2:
(6 comments)
You should not score your on change-set.
https://review.coreboot.org/#/c/31803/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: coreboot,and Please add a space after the comma (,).
https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: cbfs(CL:*990403) Please add a space before the opening bracket (.
https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: vbt VBT
https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: remove Remove
https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@10 PS2, Line 10: to fix the bugs Please elaborate, what bug is fixed. Not all reviewers have access to the bug report.
https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: remove the bard vbt bin in coreboot,and add it in cbfs(CL:*990403) : to fix the bugs Please add a dot/period at the end.