Attention is currently required from: Evgeny Zinoviev, Felix Singer.
Angel Pons has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83782?usp=email )
Change subject: mb/apple/macbookair4_2: Clean up devicetree ......................................................................
Patch Set 1: Code-Review+2
(4 comments)
File src/mainboard/apple/macbookair4_2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83782/comment/b214677d_05271612?usp... : PS1, Line 2: register "gfx.did" = "{ 0x80000410, 0x80000320, 0x80000410, 0x80000410, 0x00000005 }" : register "gfx.ndid" = "2" For another patch: trim `gfx.did` to size (`gfx.ndid` is 2)
https://review.coreboot.org/c/coreboot/+/83782/comment/6f04c0ad_225fed52?usp... : PS1, Line 36: subsystemid 0x8086 0x7270 For another patch: inherit the subsystemid
https://review.coreboot.org/c/coreboot/+/83782/comment/4f653065_b865aa50?usp... : PS1, Line 63: device ref host_bridge on : subsystemid 0x106b 0x00eb : end : device ref peg10 on : subsystemid 0x106b 0x00eb : end : device ref igd on : subsystemid 0x106b 0x00eb : end For another patch: put northbridge devices "north of" (above) southbridge (PCH) devices
https://review.coreboot.org/c/coreboot/+/83782/comment/d050cc93_610697f8?usp... : PS1, Line 72: device pci 1a.7 on : subsystemid 0x8086 0x7270 : end : device pci 1d.7 on : subsystemid 0x8086 0x7270 : end For another patch: these are functions of the EHCI controllers, and don't seem to exist when the RMH (Rate Matching Hub) is enabled. So I would remove them.