HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45677 )
Change subject: soc/intel: Use ASL 2.0 syntax for GPIO ASL helper function ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... File src/soc/intel/skylake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 27: Store (^^PCRB (PID_GPIOCOM0), BAS0) : Store old syntax
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 33: Store (^^PCRB (PID_GPIOCOM1), BAS1) : Store old
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 39: Store (^^PCRB (PID_GPIOCOM3), BAS3) : Store old
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 43: And ( old
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 46: LEqual ( old
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 47: Store (GPIO_IRQ14, IRQN) : } Else { : Store old
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 69: And (LGreaterEqual (Arg0, GPP_A0), LLessEqual (Ar old
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 71: Store (PID_GPIOCOM0, Local0) : Subtract (Arg0, GPP_A0, Local1) : } : /* GPIO Community 1 */ : If (LAnd (LGreaterEqual (Arg0, GPP_C0), LLessEqual (Arg0, GPP_H23))) : { : Store (PID_GPIOCOM1, Local0) : Subtract (Arg0, GPP_C0, Local1) : } : /* GPIO Community 03 */ : If (LAnd (LGreaterEqual (Arg0, GPP_I0), LLessEqual (Arg0, GPP_I10))) : { : Store (PID_GPIOCOM3, Local0) : Subtract (Arg0, GPP_I0, Local1) : } : #else : /* GPIO Community 0 */ : If (LAnd (LGreaterEqual (Arg0, GPP_A0), LLessEqual (Arg0, GPP_B23))) : { : Store (PID_GPIOCOM0, Local0) : Subtract (Arg0, GPP_A0, Local1) : } : /* GPIO Community 1 */ : If (LAnd (LGreaterEqual (Arg0, GPP_C0), LLessEqual (Arg0, GPP_E23))) : { : Store (PID_GPIOCOM1, Local0) : Subtract (Arg0, GPP_C0, Local1) : } : /* GPIO Community 03*/ : If (LAnd (LGreaterEqual (Arg0, GPP_F0), LLessEqual (Arg0, GPP_G7))) : { : Store (PID_GPIOCOM3, Local0) : Subtract (Arg0, old
https://review.coreboot.org/c/coreboot/+/45677/1/src/soc/intel/skylake/acpi/... PS1, Line 106: Store (PCRB (Local0), Local2) : Add ( old