Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board
......................................................................
Patch Set 63:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35864/63/src/mainboard/lenovo/t60/K...
File src/mainboard/lenovo/t60/Kconfig:
https://review.coreboot.org/c/coreboot/+/35864/63/src/mainboard/lenovo/t60/K...
PS63, Line 35: t60
typo?
scratch that, just realized what this is.
default "t60" if BOARD_LENOVO_T60 || BOARD_LENOVO_R60
would make the intention clearer, I guess
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd9208a5eafd228f8eedbc8fb4f4eb9ed1932a14
Gerrit-Change-Number: 35864
Gerrit-PatchSet: 63
Gerrit-Owner: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 24 Oct 2019 22:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment