Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58114 )
Change subject: soc/amd/common/block/lpc: Refactor ESPI Setup ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2: some i like this patch
File src/soc/amd/cezanne/early_fch.c:
https://review.coreboot.org/c/coreboot/+/58114/comment/b2fa9c8c_43ddbf63 PS2, Line 39: enable_acpimmio_decode_pm04(); this should probably be done in another patch, but enable_acpimmio_decode_pm04 needs to be moved to be the first call in fch_pre_init. this will allow the mb_set_up_early_espi function that might get called in lpc_early_init to access the acpimmio region which it'll typically do. This change should also be done on all other soc/amd platforms. maybe take over CB:57782 for this? or should i do the change?
File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/58114/comment/1b0c6e87_4e5c8c32 PS2, Line 367: ESPI i think it's eSPI with a lower case e. same in the commit message
https://review.coreboot.org/c/coreboot/+/58114/comment/f7200486_a39f8e12 PS2, Line 369: !CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) && this gets skipped in the case of verstage on psp to not initialize eSPI twice, right?