Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41420 )
Change subject: lib: Add strtok() and strtok_r()
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41420/7/src/include/string.h
File src/include/string.h:
https://review.coreboot.org/c/coreboot/+/41420/7/src/include/string.h@32
PS7, Line 32: char *strtok(char *str, const char *delim);
: char *strtok_r(char *str, const char *delim, char **ptr);
Once you have changed the order in the header file you should do it in the c file as well so that they match again. I guess this is what Paul was trying to say.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic855b31669be1c274cbf247c53ffa6f74ec5bf35
Gerrit-Change-Number: 41420
Gerrit-PatchSet: 7
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 May 2020 06:43:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment