Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Hello Jg Daolongzhu, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58053
to look at the new patch set (#4).
Change subject: soc/mediatek: Fix I2C failures by adjusting AC timing and bus speed ......................................................................
soc/mediatek: Fix I2C failures by adjusting AC timing and bus speed
1. The original algorithm for I2C speed cannot always make the timing meet I2C specification so a new algorithm is introduced to calculate the timing parameters more correctly. 2. Some I2C buses should be initialized in a different speed while the original implementation was fixed at fast mode (400Khz). So the mtk_i2c_bus_init is now also taking an extra speed parameter.
There is an equivalent change in kernel side: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/dr...
BUG=b:189899864 TEST=Test on Tomato, boot pass and timing pass at 100/300/400/500/800/1000Khz.
Signed-off-by: Daolong Zhu jg_daolongzhu@mediatek.corp-partner.google.com Change-Id: Id25b7bb3a76908a7943b940eb5bee799e80626a0 --- M src/mainboard/google/cherry/bootblock.c M src/mainboard/google/cherry/mainboard.c M src/mainboard/google/cherry/romstage.c M src/soc/mediatek/common/i2c.c M src/soc/mediatek/common/include/soc/i2c_common.h M src/soc/mediatek/mt8195/i2c.c M src/soc/mediatek/mt8195/include/soc/i2c.h 7 files changed, 341 insertions(+), 74 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/58053/4