Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58039 )
Change subject: soc/intel/common/../cse: Allow D0i3 enable/disable for all CSE devices
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/58039/comment/05fcabfe_0d40c4f2
PS5, Line 291: pci_devfn_t dev);
:
: /* Function that put the CSE into desired state based on `requested_state` */
: bool set_cse_device_state(unsigned int devfn,
In hindsight, this is kind of an odd API now, with one function taking a PCI_DEV and the other one a PCI_DEVFN. Does it make sense to pick one type for both of these?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58039
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe819e690c47453eaee02e435525a25b576232b5
Gerrit-Change-Number: 58039
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 01 Oct 2021 20:00:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment