Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34450 )
Change subject: string: implement strspn, strcspn, atol
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c@142
PS3, Line 142: while (*p != 0) {
nit: maybe better? […]
Done
https://review.coreboot.org/c/coreboot/+/34450/3/src/lib/string.c@147
PS3, Line 147: 0
nit: maybe that's just me, but in string contexts I prefer to write these as '\0' for clarity.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8fa880357124b620bde8884949bd8ffff7d0762
Gerrit-Change-Number: 34450
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yuji Sasaki
sasakiy@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 02 Aug 2019 18:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment