Attention is currently required from: Angel Pons, Leah Rowe, Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80717?usp=email )
Change subject: nb/haswell: Disable iGPU when dGPU is used ......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/80717/comment/7a999253_55af9a1b : PS2, Line 469: dev->enabled = 0;
It looks odd indeed. I guess for the original i945 it made no difference, but here (and in snb) we have things like power management to configure (and resource allocation could be nice too).
It seems worth to test again with `dev->enabled` left untouched.
On i945 it's indeed meaningless, romstage messes with IGD if the PEG slot is filled. It's not possible to use PEG and the IGD at the same time last time I tried on i945. On later gens that worked just fine, regardless of what device is decoding VGA.