29 Jun
2023
29 Jun
'23
7:11 p.m.
Attention is currently required from: Arthur Heymans, Elyes Haouas, Felix Singer, Lance Zhao, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76143?usp=email )
Change subject: acpi/acpi.c: Move ACPI header creation to a function ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76143/comment/0727fe63_c90700af : PS3, Line 125: header->asl_compiler_revision = asl_revision; Unrelated, for acpigen-generated tables replicating ACPICA / IASL date makes no sense.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76143?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2e54d61970294e028a61ba86c07c5482784e307
Gerrit-Change-Number: 76143
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 29 Jun 2023 19:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment