Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45590 )
Change subject: soc/intel/common/block/lpc: add acpi name ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/... File src/soc/intel/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/... PS1, Line 101: return "LPCB";
One tab is enough
Done
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/... PS1, Line 101: LPCB
We should now drop "LPCB" from SoC chip functions: […]
Thanks. Since only apollolake select CONFIG_SOC_INTEL_COMMON_BLOCK_LPC, I updated apollolake accordingly.
https://review.coreboot.org/c/coreboot/+/45590/1/src/soc/intel/common/block/... PS1, Line 112: .acpi_name = lpc_acpi_name,
Looks like the other entries are aligned with tabs.
Done