Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40006 )
Change subject: mb/google/ripto: Enable DMI/SATA power Optimizer ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40006/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40006/6//COMMIT_MSG@7 PS6, Line 7: O lower-case "o"
https://review.coreboot.org/c/coreboot/+/40006/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/ripto/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40006/6/src/mainboard/google/voltee... PS6, Line 8: DmiPwrOptimizeDisable" = "1" Given the change in variable name and functionality, PwrOptimize is now enabled by default. This patchset's commit message states that the purpose of this patch is to enable PwrOptimize. Given that is now default behavior, this patch is no longer required, correct?
Or if intent of this patch is to disable the power optimizer, then please change the commit message to indicate such. Thanks.