Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )
Change subject: soc/intel/skylake: rework and fix platform detection
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35763/7/src/soc/intel/skylake/chip_...
File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35763/7/src/soc/intel/skylake/chip_...
PS7, Line 126: {
This was correctly indented before. Either two tabs or aligned with the `(`. […]
oops... that wasn't intended
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida60f619308388adc180a5652908e5a947c17c0f
Gerrit-Change-Number: 35763
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Oct 2019 15:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment