Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45078 )
Change subject: soc/intel/elkhartlake: Update Kconfig ......................................................................
Patch Set 3:
(2 comments)
Patch Set 2:
(2 comments)
Do you mind to add MAX_CPUS to the Kconfig as on a different patch (CB:45063) we have missed this define for APL and need to fix it now.
The original implementation is to put it in mainboard folder to accommodate some platforms like cfl which has different max cpus for different boards (S & H), but i think the right way should put in SOC folder. moving it here per requested :)
https://review.coreboot.org/c/coreboot/+/45078/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45078/1//COMMIT_MSG@16 PS1, Line 16: I2c
I2C
Done
https://review.coreboot.org/c/coreboot/+/45078/2/src/soc/intel/elkhartlake/K... File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/45078/2/src/soc/intel/elkhartlake/K... PS2, Line 76: default 0x30000
This results in 192 kB while the help text is changed to 128 kB. […]
Done