Attention is currently required from: Arthur Heymans, Benjamin Doron, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81072?usp=email )
Change subject: soc/amd/genoa_poc: Fix DEBUG_SMI compilation error
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81072/comment/2a928d2d_5e0ded25 :
PS1, Line 7: Fix DEBUG_SMI compilation error
I’d make it more about the action.
Something like this?
soc/amd/genoa_poc: Allow using UART with DEBUG_SMI=y
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81072?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7c6f2346d5f9ffb371d51d1de6f0b695acedf10
Gerrit-Change-Number: 81072
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 04 Apr 2024 08:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment