Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34523 )
Change subject: soc/qualcomm/qcs405: Handle unknown QUP and BLSP ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
I found this: https://www.inforcecomputing.com/public_docs/BLSPs_on_Inforce_6540_6501_Snap...
Looks like QUP stands for "Qualcomm Universal Peripheral", and BLSP stands for "BAM Low Speed Peripheral", where BAM means "Bus Access Manager/Module". Maybe you want to update the "QUP not supported" message?
https://review.coreboot.org/c/coreboot/+/34523/2/src/soc/qualcomm/qcs405/clo... File src/soc/qualcomm/qcs405/clock.c:
https://review.coreboot.org/c/coreboot/+/34523/2/src/soc/qualcomm/qcs405/clo... PS2, Line 218: case 0: : spi_clk = (struct qcs405_clock *) : &gcc->blsp1_qup0_spi_clk; : break; : case 1: : spi_clk = (struct qcs405_clock *) : &gcc->blsp1_qup1_spi_clk; : break; : case 2: : spi_clk = (struct qcs405_clock *) : &gcc->blsp1_qup2_spi_clk; : break; : case 3: : spi_clk = (struct qcs405_clock *) : &gcc->blsp1_qup3_spi_clk; : break; : case 4: : spi_clk = (struct qcs405_clock *) : &gcc->blsp1_qup4_spi_clk; Not on this patch, but I guess this could fit in one line with the new 96 character line length.
https://review.coreboot.org/c/coreboot/+/34523/2/src/soc/qualcomm/qcs405/clo... PS2, Line 239: pri I guess "Invalid QUP %d\n" would be better