Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43510 )
Change subject: tests: Add lib/bootmem-test test case ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43510/1/tests/lib/bootmem-test.c File tests/lib/bootmem-test.c:
https://review.coreboot.org/c/coreboot/+/43510/1/tests/lib/bootmem-test.c@93 PS1, Line 93: test_
Hmm.. while it is not actually a test, it is tightly coupled with a particular test. […]
How about test_bootmem_write_mem_table, setup_bootmem_write_mem_table, and teardown_bootmem_write_mem_table? Similarly, test_bootmem_walk, setup_bootmem_walk, and teardown_bootmem_walk.
"There are only two hard things in Computer Science: cache invalidation and naming things." -- Phil Karlton :-D
https://review.coreboot.org/c/coreboot/+/43510/1/tests/lib/bootmem-test.c@15... PS1, Line 150: bool
These functions are callbacks defined as […]
Ack