Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42551 )
Change subject: hatch: Create wyvern variant ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42551/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/wyvern/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42551/1/src/mainboard/google/hatch/... PS1, Line 4: SPD_SOURCES =
Those files don't exist in the Wyvern source, because they don't exist in the template directory.
https://review.coreboot.org/c/coreboot/+/42551/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/wyvern/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/42551/1/src/mainboard/google/hatch/... PS1, Line 2: : #include <baseboard/acpi/dptf.asl>
I will make a common puff dptf.asl as well since we diverged from baseboard vanilla.
The idea for the first patch is that it's a duplicate of the reference board, no changes. Follow-on CLs make the changes to match up with the hardware.
https://review.coreboot.org/c/coreboot/+/42551/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/wyvern/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/42551/1/src/mainboard/google/hatch/... PS1, Line 5: : #include <baseboard/ec.h>
our ec. […]
As for dptf, this CL is only supposed to exactly copy the reference board.
https://review.coreboot.org/c/coreboot/+/42551/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/wyvern/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42551/1/src/mainboard/google/hatch/... PS1, Line 1: chip soc/intel/cannonlake : : device domain 0 on : end : : end
We should somehow work out how to improve making puff overrides more copy-able if we can't do multi- […]
Ack