Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82765?usp=email )
Change subject: via: Start template for VIA C7 w/ CX700 northbridge ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/northbridge/via/cx700/clock.c:
https://review.coreboot.org/c/coreboot/+/82765/comment/a59988f4_e90e72ae?usp... : PS1, Line 20: default:
They are not officially supported. I guess it won't hurt much to add them, though. […]
Ack
File src/northbridge/via/cx700/clock.c:
https://review.coreboot.org/c/coreboot/+/82765/comment/f14aea0c_8ed33448?usp... : PS2, Line 26: return 200;
Changed this too, because assuming too high makes delays too long, which […]
Makes sense. Although I just recalled CB:49939 and an associated bug that might still exist: logging from `get_timer_fsb()` can result in infinite recursion because the logging functions call the timer stuff.